Smileys not converting right after import vBulletin forum

Originally posted this in the "Creating Styles" section, but I guess it was the wrong subforum.

I'm having a problem with old smilies on my forum.

Burningboard needs a space before and after the smiley in order to turn it into the image, but in practice that kinda beats a big protion of the smilies we have in place. Anyone has an idea?

(screenshot)
https://gyazo.com/aa52fb9c7fdcf53fcda0b14336104c73

EDIT:

I found a thread on the support forum of phpbb with the same issue, and they fixed it. Unfortunatly I have no idea where to start looking in Burning Board.

https://www.phpbb.com/community/viewtopic.php?f=72&t=2168761
https://www.phpbb.com/community/viewtopic.php?f=46&t=1928675

EDIT 2:

I'm just trying a bunch of stuff. Let me know if you think I'm on the right track. Because I haven't got a clue what I'm doing.

In the \wcf\acp\templates folder I found bbcodeAdd.tpl, bbcodeList.tpl, bbcodeMediaproviderAdd.tpl, bbcodeMediaProviderList.tpl & bbCodeSelectOptionType.
I also found SmileyList & SmileyAdd.tpl

I presume I should alter one of those files in the same fashion as suggested in the phpbb link I provided.

Anyone knows how exactly to do this?

Hi Morik,

Thanks for the answer.

The problem is that most of my members will copy paste poker hand histories from a third party software, and it's output is without the whitespace. Given the nature of the board (a pokerforum) I'm pretty sure this is an essential item that I need to fix

An example:

[converted_hand][hand_history]Poker Stars, $0.10/$0.25 No Limit Hold'em Cash, 6 Players

SB: $28.64 (114.6 bb)
BB: $39.69 (158.8 bb)
UTG: $25.25 (101 bb)
MP: $49.26 (197 bb)
CO: $25.22 (100.9 bb)
Hero (BTN): $42.17 (168.7 bb)

Preflop: Hero is BTN with 6:spade: 6:heart:
[color="red"]UTG raises to $0.75[/color], 2 folds, Hero calls $0.75, [color="grey"]SB folds[/color], BB calls $0.50

Flop: ($2.35) T:spade: 6:diamond: T:club:[color="blue"] (3 players)[/color]
BB checks, UTG checks, [color="red"]Hero bets $1.90[/color], BB calls $1.90, [color="grey"]UTG folds[/color]

Turn: ($6.15) 4:spade:[color="blue"] (2 players)[/color]
BB checks, [color="red"]Hero bets $5[/color], [color="red"]BB raises to $13[/color], [color="red"]Hero raises to $39.52 and is all-in[/color], BB calls $24.04 and is all-in

River: ($80.23) 8:spade:[color="blue"] (2 players, 2 are all-in)[/color]

[spoil]Results: $80.23 pot ($2 rake)
Final Board: T:spade: 6:diamond: T:club: 4:spade: 8:spade:
BB showed T:heart: A:spade: and lost (-$39.69 net)
Hero showed 6:spade: 6:heart: and won $78.23 ($38.54 net)
[/spoil][/hand_history][/converted_hand]

We also use [Ad] smiley codes for cards. And they suffer from the same thing.

Apparently the answer has just been in front of us the whole time.

MessageParser.class.php has the following code on lines 255-281

/**




* Parses smiley codes.




*




* @param string$text




* @return stringtext




*/




protected function parseSmilies($text, $enableHtml = false) {




foreach ($this->smilies as $code => $html) {




//$text = preg_replace('~(?<!&\w{2}|&\w{3}|&\w{4}|&\w{5}|&\w{6}|&#\d{2}|&#\d{3}|&#\d{4}|&#\d{5})'.preg_quote((!$enableHtml ? StringUtil::encodeHTML($code) : $code), '~').'(?![^<]*>)~', $html, $text);




$text = preg_replace('~(?<=^|\s|<li>)'.preg_quote((!$enableHtml ? StringUtil::encodeHTML($code) : $code), '~').'(?=$|\s|</li>'.(!$enableHtml ? '|<br />' : '').')~', $html, $text);




}










return $text;




}

So all I had to do was "activate" line 271 (17 here) and "deactivate" line 273 (19 here). By doing so apparently you don't need the whitespace to parse smileys / smilies.

Keep in mind that I have no PHP knowledge. I did however knew that // kinda makes a line not work (expert explanation), realized that they looked similar and tried adjusting it.

Kinda weird noone here knew this. Hope this shows up in searches by people, because I'm obviously not the only one that will have this issue.