Fehler im englischen Sprachpaket

Throwholics, could you start posting about English language variables in the English side of the site in English of course? Cause I don't have German language enabled on here, and the only way I saw this thread was because Alex user tagged me.

For this one, you mean something like this:

Content between BBCode tags would be used as attribute value unless it was explicitly specified.

or:

Content between BBCode tags is used as attribute value unless it was explicitly specified. ?

For the second one, I did alter it a little bit before, and altered it again not long ago but it wasn't merged yet... This is current one pending at github:

Users can login from multiple devices (desktop, tablet, smartphone, etc) concurrently, all devices will share the same session. Disabling this will restrict users to only one device (session) at a time, causing all the other device sessions to terminate. It is not recommended to disable this option.

I notice in your proposal to include semicolon after "concurrently"? I guess I could put that in there quick.

Users can login from multiple devices (desktop, tablet, smartphone, etc) concurrently; all devices will share the same session. Disabling this will restrict users to only one device (session) at a time, causing all the other device sessions to terminate. It is not recommended to disable this option.

For 3, 4, and number 5, they're ones I was going to work on at some point in time, but I didn't get there yet... Because there's ones similar in the other products, and was planning on wording them them all to be fairly consistent throughout each product's language files. But dropping the comma in there wouldn't be right, and would sound off... Need that "pause" with comma in there, unless it's reworded better and might not need it.

For number 6 there, I dropped the "s" on "counts". And also changed "for" to "of" because the counts belong to forums, shows ownership/related to forums. http://www.talkenglish.com/grammar/prepos…-of-to-for.aspx

<item name="wcf.acp.option.wbb_board_list_enable_stats"><![CDATA[Display thread and post count of each forum]]></item> Will submit to pull request after while then.

For number 7 there, all of those have been revamped again for all the products keeping them consistent, to point, short, sweet, understandable etc. Too many commas there is too much, not needed lol.

For number 8 there, all of those in all products have been revamped as well... They're like this now...

"Notify me of new posts." - burning board
"Notify me of new images." - gallery
"Notify me of new articles." - blog
etc

Quote from Throwholics

Sorry I did not really think about that to be frank
I was just going through the language files and saw those mistakes.

If I come up something similar again I will change to English. (I just changed for this thread though)

Yeah, probably didn't think about it because you didn't know I was working on English lang files since 4.1.10 and still doing it (basically alone, without anyone's help) ... Lol. Well, of course Alex, Rafix73, and my family helping/suggesting here and there haha.

Had I known your English grammar was great/better than mine (and I'm an English guy, of course still not great with English grammar lol.), I would have added you on Skype messenger and we could have knocked these out together and quicker.. lmao. A lot of these you put in here though weren't done by me, they've been the ones in the software since I started working on phrases.

Quote from Throwholics

Yes it should be "would" instead of will, because the "if" clause (unless) is past tense.
I just noticed that my suggestion was erased while adding other inline code blocks.....

Gotcha, made the changes, will submit pull request to github then.

Quote from Throwholics

Yes but also the "." after etc. should always be included.

Got it, made the changes, will submit pull request then. But in all honesty, didn't think the period was required there between ( ) after "etc" unless it formed sentence.. Didn't think it was required if just bunch of words within commas. Learn something new every day I guess, even if it's English grammar from a German guy.. lol

Quote from Throwholics

Actually the comma is unnessesary and simply not needed. It might sound off but grammar wise it is redundant.

We'll probably agree to disagree about this one cause of course to me it sounds wrong/off without the comma lol. Might be better to say like "This post requires approval by a moderator so until then it will remain invisible for others."

See, all of these types I had planned to do eventually, but wanted to knock out the basic ones first, then put all focus on these types within all the products at once so my brain was concentrating on just these ones at same time... It's easier to have all product's lang files open at same time, playing with wording, meaning, etc... To see how they sound, work, mean, etc. Lol

Quote from Throwholics

But isn't it plural thread and post ? But i guess its argueable

You mean, keep it like this now? Thought you wanted to drop the "s"?

Display thread and post counts of each forum - this is what I had originally, since there's two countS, not just one count.

Quote from Throwholics

Alright, like your short suggestion. I was simply based on the grammar errors (Missing comma(s) with interrupter) in that sentence.

lol it's alright..

Quote from Throwholics

Perfect!

Quote from Throwholics

But then it should not counts! haha

he/she/it the s is needed
the rest without
plural

lmfao... you're right, not sure what i was thinking, if i was thinking at all at the time .. Lol

This thread can be marked "fixed" I guess, only the following below weren't handled yet for phrase adjustments, which I plan to do in near future here...Or, could make new bug thread with these below included in it... The majority in this thread were handled /fixed of course.

Quote from Throwholics

3. Fehler:

<item name="wbb.post.moderation.disabledPost"><![CDATA[This post requires approval by a moderator, until then it will remain invisible for others.]]></item>
sollte sein:

This post requires approval by a moderator until then it will remain invisible for others.

4. Fehler (It appears that you have an unnecessary comma before the dependent clause marker until.)

<item name="wbb.post.moderation.disabledPost"><![CDATA[This post requires approval by a moderator, until then it will remain invisible for others.]]></item>

sollte sein:

<item name="wbb.post.moderation.disabledPost"><![CDATA[This post requires approval by a moderator, until then it will remain invisible to others.]]></item>

5. Fehler:

<item name="wbb.thread.moderation.disabledThread"><![CDATA[This thread requires approval by a moderator, until then it will remain invisible for others.]]></item>

Sollte sein:

<item name="wbb.thread.moderation.disabledThread"><![CDATA[This thread requires approval by a moderator until then it will remain invisible for others.]]></item>

Display More

Quote from Throwholics

Thanks for the pull requests.

You're welcome.

Quote from Throwholics

How do you proceed anyway?

@Alexander Ebert or other staff might be better to explain and what would need done to move forward and the "access" that would be needed etc. In the beginning I was limited to certain repos, which didn't help anyone. Because I kept doing changes to lang files on my computer, then had to submit bug threads with proposed changes, then the developers had to make the changes each time. Then had to learn some github'ing, which of course I'm still learning.. Lol

Quote from Throwholics

Do you take the en.xml file and look manually for everything?

When I first started I did the phrases in sections of the ACP/front-end of site. Like, I'd work on phrases for the Rebuild Data page, and manually changed the values of the lang phrases to "custom values". I had to copy/select each phrase I wanted to tweak from that page, enter it into the search phrases field for "Content" and then once it displayed, I clicked on it to manually add custom value change I wanted to use.

Then when I got the phrases done like I wanted to be, I came to here and filed bug threads about all the changes, then devs took care of it. Now, I kind of do the same thing, but do it with github, after forking all their repos to my github profile, then cloning them all onto hard drive and make changes to those lang files... I'd also import the lang file as I go along to see how things look, and if okay, I'll submit the pull requests via github desktop app.

Quote from Throwholics

It would be so much easier if there was a file with only the language parts in it.

Yeah, and no lang variables themselves, just the phrases.. But it would be confusing after while, because you wouldn't know for sure where the phrases showed up/belonged to... Lol.